Forum | Documentation | Website | Blog

Skip to content
Snippets Groups Projects
  1. Apr 18, 2014
  2. Apr 17, 2014
  3. Apr 16, 2014
    • Thierry Reding's avatar
      drm/tegra: Remove gratuitous pad field · cbfbbabb
      Thierry Reding authored
      The version of the drm_tegra_submit structure that was merged all the
      way back in 3.10 contains a pad field that was originally intended to
      properly pad the following __u64 field. Unfortunately it seems like a
      different field was dropped during review that caused this padding to
      become unnecessary, but the pad field wasn't removed at that time.
      
      One possible side-effect of this is that since the __u64 following the
      pad is now no longer properly aligned, the compiler may (or may not)
      introduce padding itself, which results in no predictable ABI.
      
      Rectify this by removing the pad field so that all fields are again
      naturally aligned. Technically this is breaking existing userspace ABI,
      but given that there aren't any (released) userspace drivers that make
      use of this yet, the fallout should be minimal.
      
      Fixes: d43f81cb
      
       ("drm/tegra: Add gr2d device")
      Cc: <stable@vger.kernel.org> # 3.10
      Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
      cbfbbabb
    • Stephen Warren's avatar
      gpu: host1x: handle the correct # of syncpt regs · 22bbd5d9
      Stephen Warren authored
      BIT_WORD() truncates rather than rounds, so the loops in
      syncpt_thresh_isr() and _host1x_intr_disable_all_syncpt_intrs() use <=
      rather than < in an attempt to process the correct number of registers
      when rounding of the conversion of count of bits to count of words is
      necessary. However, when rounding isn't necessary because the value is
      already a multiple of the divisor (as is the case for all values of
      nb_pts the code actually sees), this causes one too many registers to
      be processed.
      
      Solve this by using and explicit DIV_ROUND_UP() call, rather than
      BIT_WORD(), and comparing with < rather than <=.
      
      Fixes: 7ede0b0b
      
       ("gpu: host1x: Add syncpoint wait and interrupts")
      Cc: <stable@vger.kernel.org> # 3.10
      Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
      Acked-By: default avatarTerje Bergstrom <tbergstrom@nvidia.com>
      Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
      22bbd5d9
  4. Apr 15, 2014
  5. Apr 14, 2014