binder: use cred instead of task for selinux checks
Since binder was integrated with selinux, it has passed 'struct task_struct' associated with the binder_proc to represent the source and target of transactions. The conversion of task to SID was then done in the hook implementations. It turns out that there are race conditions which can result in an incorrect security context being used. Fix by using the 'struct cred' saved during binder_open and pass it to the selinux subsystem. Cc: stable@vger.kernel.org # 5.14 (need backport for earlier stables) Fixes: 79af7307 ("Add security hooks to binder and implement the hooks for SELinux.") Suggested-by:Jann Horn <jannh@google.com> Signed-off-by:
Todd Kjos <tkjos@google.com> Acked-by:
Casey Schaufler <casey@schaufler-ca.com> Signed-off-by:
Paul Moore <paul@paul-moore.com>
Showing
- drivers/android/binder.c 6 additions, 6 deletionsdrivers/android/binder.c
- include/linux/lsm_hook_defs.h 7 additions, 7 deletionsinclude/linux/lsm_hook_defs.h
- include/linux/lsm_hooks.h 7 additions, 7 deletionsinclude/linux/lsm_hooks.h
- include/linux/security.h 14 additions, 14 deletionsinclude/linux/security.h
- security/security.c 7 additions, 7 deletionssecurity/security.c
- security/selinux/hooks.c 13 additions, 35 deletionssecurity/selinux/hooks.c
Please register or sign in to comment