Forum | Documentation | Website | Blog

Skip to content
Snippets Groups Projects
Commit 849be516 authored by Jean Delvare's avatar Jean Delvare Committed by Jean Delvare
Browse files

i2c-ali1563: Fix device initialization


The i2c-ali1563 initialization looks quite broken to me:
* If the I/O space isn't enabled, we forcibly set 3 bits in
  the PCI configuration space instead of just the one enabling
  the I/O space.
* After that we pretend to check if the write worked, but we
  don't actually read the new value from the register.
* It's probably not a good idea to enable the I/O space if no
  base address has been set.

So I propose the following changes to that part of the driver:
* Merge ali1563_enable() into ali1563_setup().
* Check the base address before the I/O space enabled bit.

Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
Acked-by: default avatarRudolf Marek <r.marek@assembler.cz>
parent 69735698
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment