Forum | Documentation | Website | Blog

Skip to content
Snippets Groups Projects
Commit 28ce942f authored by Ming Lei's avatar Ming Lei Committed by Jens Axboe
Browse files

block: move blk_exit_queue into disk_release


There can't be file system I/O in disk_release(), so move the call to
blk_exit_queue() there, preparing to have the teardown of file system I/O
only functionality in one place, when the gendisk that is needed for it
is torn down.

We still need to freeze queue here since the request is freed after the
bio is completed and passthrough request rely on scheduler tags as well.

The disk can be released before or after queue is cleaned up, and we have
to free the scheduler request pool before blk_cleanup_queue returns,
while the static request pool has to be freed before exiting the
I/O scheduler.

Signed-off-by: default avatarMing Lei <ming.lei@redhat.com>
[hch: rebased, updated the commit log]
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarBart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20220308055200.735835-13-hch@lst.de


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent ba3e8456
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment