Forum | Documentation | Website | Blog

Skip to content
Snippets Groups Projects
  1. Oct 09, 2017
  2. Oct 01, 2017
  3. Sep 24, 2017
  4. Sep 21, 2017
    • Shuah Khan's avatar
      Makefile: kselftest and kselftest-clean fail for make O=dir case · 2bc84526
      Shuah Khan authored
      
      kselftest and kselftest-clean targets fail when object directory is
      specified to relocate objects. Fix it so it can find the source tree
      to build from.
      
      make O=/tmp/kselftest_top kselftest
      
      make[1]: Entering directory '/tmp/kselftest_top'
      make[2]: Entering directory '/tmp/kselftest_top'
      make[2]: *** tools/testing/selftests: No such file or directory.  Stop.
      make[2]: Leaving directory '/tmp/kselftest_top'
      ./linux-kselftest/Makefile:1185: recipe for target
      'kselftest' failed
      make[1]: *** [kselftest] Error 2
      make[1]: Leaving directory '/tmp/kselftest_top'
      Makefile:145: recipe for target 'sub-make' failed
      make: *** [sub-make] Error 2
      
      Signed-off-by: default avatarShuah Khan <shuahkh@osg.samsung.com>
      Acked-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
      2bc84526
  5. Sep 16, 2017
  6. Sep 14, 2017
    • Greg Kroah-Hartman's avatar
      firmware: delete in-kernel firmware · 5620a0d1
      Greg Kroah-Hartman authored
      
      The last firmware change for the in-kernel firmware source code was back
      in 2013.  Everyone has been relying on the out-of-tree linux-firmware
      package for a long long time.
      
      So let's drop it, it's baggage we don't need to keep dragging around
      (and having to fix random kbuild issues over time...)
      
      Cc: Kyle McMartin <kyle@kernel.org>
      Cc: Andrew Morton <akpm@linux-foundation.org>
      Cc: Michal Marek <mmarek@suse.com>
      Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
      Acked-by: default avatarDavid Woodhouse <dwmw2@infradead.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      5620a0d1
  7. Sep 03, 2017
  8. Aug 31, 2017
    • Masahiro Yamada's avatar
      kbuild: use $(abspath ...) instead of $(shell cd ... && /bin/pwd) · 8e9b4667
      Masahiro Yamada authored
      Kbuild conventionally uses $(shell cd ... && /bin/pwd) idiom to get
      the absolute path of the directory because GNU Make 3.80, the minimal
      supported version at that time, did not support $(abspath ...) or
      $(realpath ...).
      
      Commit 37d69ee3
      
       ("docs: bump minimal GNU Make version to 3.81")
      dropped the GNU Make 3.80 support, so we are now allowed to use those
      make-builtin helpers.
      
      This conversion will provide better portability without relying on
      the pwd command or its location /bin/pwd.
      
      I am intentionally using $(realpath ...) instead $(abspath ...) in
      some places.  The difference between the two is $(realpath ...)
      returns an empty string if the given path does not exist.  It is
      convenient in places where we need to error-out if the makefile fails
      to create an output directory.
      
      Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
      Acked-by: default avatarThierry Reding <treding@nvidia.com>
      8e9b4667
  9. Aug 27, 2017
  10. Aug 20, 2017
  11. Aug 13, 2017
  12. Aug 09, 2017
  13. Aug 06, 2017
  14. Jul 30, 2017
  15. Jul 23, 2017
  16. Jul 15, 2017
  17. Jul 12, 2017
    • Linus Torvalds's avatar
      disable new gcc-7.1.1 warnings for now · bd664f6b
      Linus Torvalds authored
      
      I made the mistake of upgrading my desktop to the new Fedora 26 that
      comes with gcc-7.1.1.
      
      There's nothing wrong per se that I've noticed, but I now have 1500
      lines of warnings, mostly from the new format-truncation warning
      triggering all over the tree.
      
      We use 'snprintf()' and friends in a lot of places, and often know that
      the numbers are fairly small (ie a controller index or similar), but gcc
      doesn't know that, and sees an 'int', and thinks that it could be some
      huge number.  And then complains when our buffers are not able to fit
      the name for the ten millionth controller.
      
      These warnings aren't necessarily bad per se, and we probably want to
      look through them subsystem by subsystem, but at least during the merge
      window they just mean that I can't even see if somebody is introducing
      any *real* problems when I pull.
      
      So warnings disabled for now.
      
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      bd664f6b
  18. Jul 11, 2017
  19. Jul 09, 2017
  20. Jul 02, 2017
  21. Jun 29, 2017
    • Nicholas Piggin's avatar
      kbuild: handle libs-y archives separately from built-in.o archives · 3a166fc2
      Nicholas Piggin authored
      
      The thin archives build currently puts all lib.a and built-in.o
      files together and links them with --whole-archive.
      
      This works because thin archives can recursively refer to thin
      archives. However some architectures include libgcc.a, which may
      not be a thin archive, or it may not be constructed with the "P"
      option, in which case its contents do not get linked correctly.
      
      So don't pull .a libs into the root built-in.o archive. These
      libs should already have symbol tables and indexes built, so they
      can be direct linker inputs. Move them out of the --whole-archive
      option, which restore the conditional linking behaviour of lib.a
      to thin archives builds.
      
      Signed-off-by: default avatarNicholas Piggin <npiggin@gmail.com>
      Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
      3a166fc2
  22. Jun 25, 2017
  23. Jun 24, 2017
  24. Jun 23, 2017
  25. Jun 21, 2017
  26. Jun 19, 2017
  27. Jun 11, 2017
  28. Jun 09, 2017
    • Masahiro Yamada's avatar
      kbuild: remove duplicated arch/*/include/generated/uapi include path · f8224f7f
      Masahiro Yamada authored
      Commit 90ac086b ("Makefile: include arch/*/include/generated/uapi
      before .../generated") introduced this for bisect'ability.  The commit
      chose to promote arch/*/include/generated/uapi in the search path
      rather than cleaning stale headers.
      
      After all, we found that approach was not enough, and ended up with
      cleaning stale headers by commit cda2c65f ("kbuild: Remove stale
      asm-generic wrappers").
      
      So, the extra search path is no longer needed because Kbuild invokes
      scripts/Makefile.asm-generic and remove stale headers before it starts
      descending.
      
      This commit is also reverting commit dc33db7c
      
       ("Kbuild: avoid
      duplicate include path") because we have no more duplicated path.
      
      Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
      f8224f7f
  29. Jun 06, 2017
  30. Jun 05, 2017
    • Masahiro Yamada's avatar
      kbuild: simplify silent build (-s) detection · 6f0fa58e
      Masahiro Yamada authored
      This allows to detect -s (--silent) option without checking GNU Make
      version.
      
      As commit e36aaea2 ("kbuild: Fix silent builds with make-4")
      pointed out, GNU Make 4.x changed the way/order it presents the
      command line options into MAKEFLAGS.
      
      In Make 3.8x, 's' is always the first in a group of short options.
      The group may be prefixed with '-' in some cases.
      
      In Make 4.x, 's' is always the last in a group of short options.
      
      As commit e6ac89fa
      
       ("kbuild: Correctly deal with make options
      which contain an 's'") addressed, we also need to deal with long
      options that contain 's', like --warn-undefined-variables.
      
      Test cases:
      
      [1] command line input:    make --silent
           -> MAKEFLAGS for Make 3.8x:    s
           -> MAKEFLAGS for Make 4.x :    s
      
      [2] command line input:    make -srR
           -> MAKEFLAGS for Make 3.8x:    sRr
           -> MAKEFLAGS for Make 4.x :    rRs
      
      [3] command line input:    make -s -rR --warn-undefined-variables
           -> MAKEFLAGS for Make 3.8x:    --warn-undefined-variables -sRr
           -> MAKEFLAGS for Make 4.x :    rRs --warn-undefined-variables
      
      My idea to cater to all the cases more easily is to filter out long
      options (--%), then search 's' with $(findstring ...).  This way will
      be more future-proof even if future versions of Make put 's' in the
      middle of the group.
      
      Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
      6f0fa58e
  31. Jun 04, 2017
  32. May 28, 2017
  33. May 21, 2017