devlink: Set device as early as possible
All kernel devlink implementations call to devlink_alloc() during initialization routine for specific device which is used later as a parent device for devlink_register(). Such late device assignment causes to the situation which requires us to call to device_register() before setting other parameters, but that call opens devlink to the world and makes accessible for the netlink users. Any attempt to move devlink_register() to be the last call generates the following error due to access to the devlink->dev pointer. [ 8.758862] devlink_nl_param_fill+0x2e8/0xe50 [ 8.760305] devlink_param_notify+0x6d/0x180 [ 8.760435] __devlink_params_register+0x2f1/0x670 [ 8.760558] devlink_params_register+0x1e/0x20 The simple change of API to set devlink device in the devlink_alloc() instead of devlink_register() fixes all this above and ensures that prior to call to devlink_register() everything already set. Signed-off-by:Leon Romanovsky <leonro@nvidia.com> Reviewed-by:
Jiri Pirko <jiri@nvidia.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
Showing
- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c 6 additions, 3 deletionsdrivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
- drivers/net/ethernet/cavium/liquidio/lio_main.c 3 additions, 2 deletionsdrivers/net/ethernet/cavium/liquidio/lio_main.c
- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.c 3 additions, 2 deletionsdrivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.c
- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c 2 additions, 2 deletionsdrivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c
- drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_devlink.c 4 additions, 3 deletionsdrivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_devlink.c
- drivers/net/ethernet/huawei/hinic/hinic_devlink.c 4 additions, 4 deletionsdrivers/net/ethernet/huawei/hinic/hinic_devlink.c
- drivers/net/ethernet/huawei/hinic/hinic_devlink.h 2 additions, 2 deletionsdrivers/net/ethernet/huawei/hinic/hinic_devlink.h
- drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c 1 addition, 1 deletiondrivers/net/ethernet/huawei/hinic/hinic_hw_dev.c
- drivers/net/ethernet/huawei/hinic/hinic_main.c 1 addition, 1 deletiondrivers/net/ethernet/huawei/hinic/hinic_main.c
- drivers/net/ethernet/intel/ice/ice_devlink.c 2 additions, 2 deletionsdrivers/net/ethernet/intel/ice/ice_devlink.c
- drivers/net/ethernet/marvell/octeontx2/af/rvu_devlink.c 3 additions, 2 deletionsdrivers/net/ethernet/marvell/octeontx2/af/rvu_devlink.c
- drivers/net/ethernet/marvell/prestera/prestera_devlink.c 4 additions, 3 deletionsdrivers/net/ethernet/marvell/prestera/prestera_devlink.c
- drivers/net/ethernet/marvell/prestera/prestera_devlink.h 1 addition, 1 deletiondrivers/net/ethernet/marvell/prestera/prestera_devlink.h
- drivers/net/ethernet/marvell/prestera/prestera_main.c 1 addition, 1 deletiondrivers/net/ethernet/marvell/prestera/prestera_main.c
- drivers/net/ethernet/mellanox/mlx4/main.c 2 additions, 2 deletionsdrivers/net/ethernet/mellanox/mlx4/main.c
- drivers/net/ethernet/mellanox/mlx5/core/devlink.c 5 additions, 4 deletionsdrivers/net/ethernet/mellanox/mlx5/core/devlink.c
- drivers/net/ethernet/mellanox/mlx5/core/devlink.h 2 additions, 2 deletionsdrivers/net/ethernet/mellanox/mlx5/core/devlink.h
- drivers/net/ethernet/mellanox/mlx5/core/main.c 2 additions, 2 deletionsdrivers/net/ethernet/mellanox/mlx5/core/main.c
- drivers/net/ethernet/mellanox/mlx5/core/sf/dev/driver.c 1 addition, 1 deletiondrivers/net/ethernet/mellanox/mlx5/core/sf/dev/driver.c
- drivers/net/ethernet/mellanox/mlxsw/core.c 3 additions, 2 deletionsdrivers/net/ethernet/mellanox/mlxsw/core.c
Please register or sign in to comment